Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex ID System page #5268

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Yandex ID System page #5268

merged 6 commits into from
Jun 17, 2024

Conversation

chernodub
Copy link
Contributor

Hi! This PR accompanies the one submitted in Prebid.js repo: prebid/Prebid.js#11196

We have added the Yandex ID system.

If any details needed, we'd be happy to provide it, thanks!

🏷 Type of documentation

  • new id system

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit e1a34b1
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/666fedb76da4100008d9c743
😎 Deploy Preview https://deploy-preview-5268--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chernodub
Copy link
Contributor Author

I am not sure why, but the module did not appear on /download.html. I would appreciate it if somebody would let me know what I missed. Thanks :)

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just realized that you also need to add a row into the table at https://docs.prebid.org/dev-docs/modules/userId.html#prebidjs-adapters

@chernodub
Copy link
Contributor Author

Hi @bretg! I've updated the file according to your recommendation.

I've also updated the “new user ID module” checklist according to your comment.

Please let me know if anything else needed. Thanks!

@bretg bretg added LGTM and removed needs work labels May 6, 2024
@bretg
Copy link
Contributor

bretg commented May 6, 2024

Thanks.

the module did not appear on /download.html

Not sure if this comment is old, but I see Yandex ID on the preview -- https://deploy-preview-5268--prebid-docs-preview.netlify.app/download

Note that the linting error here comes from a problem not related to this PR and I don't know how to fix... the linter is confused by the liquid script containing a pipe symbol. For now, ignoring the lint issue. We'll merge these docs when the code is released.

@chernodub
Copy link
Contributor Author

@bretg yep! The download page worked as expected after I updated the adapters table. Thanks a lot!

@muuki88
Copy link
Contributor

muuki88 commented Jun 13, 2024

@chernodub can you resolve the merge conflicts?

@chernodub
Copy link
Contributor Author

@muuki88 thanks! I've made the updates. Please take a look when you can :)

@muuki88 muuki88 merged commit b23b472 into prebid:master Jun 17, 2024
5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Jun 17, 2024

Awesome 😎

BIGOAds pushed a commit to BIGOAds/prebid.github.io that referenced this pull request Jul 5, 2024
* feat: add yandex id system docs

* fix: add yandex id to adapters table

* fix: update docs on how to add user id module

* fix: adjust list type

* Add storage config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants